Skip to content

[3.8] bpo-27820: Fix AUTH LOGIN logic in smtplib.SMTP (GH-24118)#24833

Merged
orsenthil merged 2 commits intopython:3.8from
orsenthil:backport-7591d94-3.8
Mar 13, 2021
Merged

[3.8] bpo-27820: Fix AUTH LOGIN logic in smtplib.SMTP (GH-24118)#24833
orsenthil merged 2 commits intopython:3.8from
orsenthil:backport-7591d94-3.8

Conversation

@orsenthil
Copy link
Copy Markdown
Member

@orsenthil orsenthil commented Mar 12, 2021 •
edited by bedevere-bot
Loading

  • Fix auth_login logic (bpo-27820)

  • Also fix a longstanding bug in the SimSMTPChannel.found_terminator() method that causes inability to test
    SMTP AUTH with initial_response_ok=False.

(cherry picked from commit 7591d94)

https://bugs.python.org/issue27820

@pepoluan @orsenthil
bpo-27820: Fix AUTH LOGIN logic in smtplib.SMTP (GH-24118)
ea3e581 
* Fix auth_login logic (bpo-27820)

* Also fix a longstanding bug in the SimSMTPChannel.found_terminator() method that causes inability to test
SMTP AUTH with initial_response_ok=False.

(cherry picked from commit 7591d94)
@orsenthil orsenthil requested a review from a team as a code owner March 12, 2021 23:38
@orsenthil orsenthil changed the title bpo-27820: Fix AUTH LOGIN logic in smtplib.SMTP (GH-24118) [3.8] bpo-27820: Fix AUTH LOGIN logic in smtplib.SMTP (GH-24118) Mar 12, 2021
@bedevere-bot bedevere-bot mentioned this pull request Mar 12, 2021
Merged
@orsenthil orsenthil merged commit 8cadc2c into python:3.8 Mar 13, 2021
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 13, 2021

@orsenthil: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@orsenthil @bedevere-bot @the-knights-who-say-ni @pepoluan